Change get_int_value() to a function in mathics.core.atoms.numerics. Remove it as an method of Element - #1934
Merged
Merged
Conversation
and other relevant classes.
However the definition of probably could be improved to redu handling "Infinity".
rocky
force-pushed
the
isolate-to-numerics-get_int_value
branch
from
September 3, 2026 20:38
f2910b0 to
386125c
Compare
Member
Author
|
@mmatera: Before we make what will look like massive changes to the code pattern and/or assignment code, I'd like this cleanup to be in place first. |
Contributor
|
LGTM. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
get_int_value()to a function inmathics.core.atoms.numerics. Remove it as an method ofElement.get_int_value()is a highly custom kind of function, not a fundamental property of an element.This is part of a long-desired reorganization of
mathics.coreto make it comprehensible and logical, and more in line with modern Python conventions..int_valueis now a property on methods only where it makes sense.